Skip to content

fix: remove quests#2501

Merged
bal7hazar merged 1 commit intomainfrom
fix/remove-quests
Mar 23, 2026
Merged

fix: remove quests#2501
bal7hazar merged 1 commit intomainfrom
fix/remove-quests

Conversation

@bal7hazar
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 23, 2026 3:34pm
keychain Ready Ready Preview Mar 23, 2026 3:34pm
keychain-storybook Ready Ready Preview Mar 23, 2026 3:34pm

Request Review

@bal7hazar bal7hazar merged commit 2f08ac0 into main Mar 23, 2026
13 checks passed
@bal7hazar bal7hazar deleted the fix/remove-quests branch March 23, 2026 15:40
@claude
Copy link
Contributor

claude bot commented Mar 23, 2026

Claude finished @bal7hazar's task —— View job


Documentation Analysis Complete

  • Analyze code changes for user-facing impact
  • Search docs repo for quest-related content
  • Determine if updates are needed
  • Remove quest documentation
  • Remove quest from sidebar config
  • Update all references

Summary

The PR removed quest UI functionality from the controller keychain. I've updated the documentation repository (docs-repo/) to reflect these changes:

Files modified:

  1. Removed src/pages/controller/quests.md - 342 lines of quest documentation including setup, API reference, and examples
  2. Updated vocs.config.ts - Removed quest entry from "Additional Features" sidebar section (lines 127-130)
  3. Updated src/public/llms.txt - Removed quest reference from controller features list
  4. Updated src/pages/controller/overview.md - Removed "quests" from feature description

Rationale:
The quest feature documentation described a frontend integration (useQuests hook, UI routes) that no longer exists. The backend quest contracts may still exist, but without frontend support, users cannot implement this feature.

Changes follow documentation rules:

  • ✅ DEFAULT TO NO CHANGES - Only updated because of concrete user-facing changes (removed UI routes)
  • ✅ SINGLE CANONICAL LOCATION - Removed the canonical quest.md page and updated cross-references
  • ✅ MINIMAL EDITS - Only touched affected sections, no restructuring
  • ✅ No branches/commits/PRs - Files updated in place as instructed

tarrencev added a commit to cartridge-gg/docs that referenced this pull request Mar 23, 2026
Updates documentation to reflect changes made in:
    fix: remove quests

    Related controller PR: cartridge-gg/controller#2501

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@rsodre rsodre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coud also delete keychain/src/components/quests/* if they're going for good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants