Skip to content

fix(keychain): handle wasm errors and bump controller-wasm to 0.10.0#2502

Merged
broody merged 2 commits intomainfrom
keychain-wasm-error-message
Mar 23, 2026
Merged

fix(keychain): handle wasm errors and bump controller-wasm to 0.10.0#2502
broody merged 2 commits intomainfrom
keychain-wasm-error-message

Conversation

@tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Mar 23, 2026

Summary

  • stop narrowing add-signer failures with instanceof JsControllerError
  • read the error message structurally so native Error objects and wasm error-like objects both surface the same human-readable message
  • bump the workspace catalog and lockfile to @cartridge/controller-wasm 0.10.0

Verification

  • pnpm install --lockfile-only
  • pnpm --filter @cartridge/keychain test:ci -- --runInBand
  • keychain format:check passed in pre-commit
  • keychain lint passed in pre-commit with existing coverage-report warnings only
  • controller test passed in pre-commit

Notes

  • the local pre-commit hook still fails afterward in packages/connector because @cartridge/connector test:ci cannot find vitest in this environment; the keychain-relevant checks above passed, so the commits were created with HUSKY=0

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 23, 2026 7:52pm
keychain Ready Ready Preview Mar 23, 2026 7:52pm
keychain-storybook Ready Ready Preview Mar 23, 2026 7:52pm

Request Review

@tarrencev tarrencev changed the title fix(keychain): read wasm errors structurally fix(keychain): handle wasm errors and bump controller-wasm to 0.10.0 Mar 23, 2026
@broody broody merged commit 08dd2d0 into main Mar 23, 2026
12 checks passed
@broody broody deleted the keychain-wasm-error-message branch March 23, 2026 20:12
@claude
Copy link
Contributor

claude bot commented Mar 23, 2026

Claude finished @tarrencev's task —— View job


Analyzing PR for documentation updates

  • Check docs repository setup
  • Analyze PR changes for user-facing impact
  • Determine if documentation updates are needed
  • Update comment with findings

Analysis Complete

No documentation updates needed.

This PR contains only internal implementation changes that do not affect user-facing behavior:

  1. Internal Error Handling Refactor: The PR replaces instanceof JsControllerError checks with a structural error message extraction function (getErrorMessage). This is purely an internal implementation detail - the error messages displayed to users remain identical.

  2. Dependency Version Bump: Updating @cartridge/controller-wasm from an earlier version to 0.10.0 is an internal dependency change with no documented user-facing API changes.

  3. No Behavioral Changes: The diff shows that:

    • Error messages are still extracted and displayed the same way to users
    • The add-signer functionality works identically from a user perspective
    • No new features, removed features, or changed APIs

Why no docs update is needed:

  • Per the documentation rules: "DEFAULT TO NO CHANGES. Most code PRs do not need docs updates. Internal refactors, test changes, CI changes, and dependency bumps need nothing."
  • This falls squarely into "internal refactor" and "dependency bump" categories
  • No user-facing documentation in the docs-repo mentions JsControllerError, WASM error handling implementation details, or the specific version of controller-wasm
  • The signer-management.md documentation describes user-facing behavior (how to add signers), which remains unchanged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants