fix(keychain): handle wasm errors and bump controller-wasm to 0.10.0#2502
Merged
fix(keychain): handle wasm errors and bump controller-wasm to 0.10.0#2502
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Claude finished @tarrencev's task —— View job Analyzing PR for documentation updates
Analysis CompleteNo documentation updates needed. This PR contains only internal implementation changes that do not affect user-facing behavior:
Why no docs update is needed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instanceof JsControllerErrorErrorobjects and wasm error-like objects both surface the same human-readable message@cartridge/controller-wasm0.10.0Verification
Notes
packages/connectorbecause@cartridge/connector test:cicannot findvitestin this environment; the keychain-relevant checks above passed, so the commits were created withHUSKY=0