fix(keychain): clear localStorage on disconnect to fix persistent login#2503
Closed
fix(keychain): clear localStorage on disconnect to fix persistent login#2503
Conversation
The WASM storage.clear() during disconnect may clear a different storage partition than where controller data was originally written. This happens when requestStorageAccess() switches the iframe from partitioned to unpartitioned localStorage during the connect flow — subsequent clear() calls target unpartitioned storage while the data remains in the partitioned partition. Add explicit localStorage.clear() calls from JS after the WASM disconnect in all disconnect/logout paths to ensure the active storage context is cleared regardless of partition state. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage.clear()may target a different storage partition than where controller data was written, due torequestStorageAccess()switching the iframe between partitioned and unpartitioned localStorage during the connect flowlocalStorage.clear()calls from JS after the WASM disconnect in all disconnect/logout paths to ensure the active storage context is always clearedTest plan
🤖 Generated with Claude Code