Skip to content

chore: remove Storage Access console logs#2507

Merged
broody merged 1 commit intomainfrom
chore/remove-storage-access-logs
Mar 24, 2026
Merged

chore: remove Storage Access console logs#2507
broody merged 1 commit intomainfrom
chore/remove-storage-access-logs

Conversation

@broody
Copy link
Contributor

@broody broody commented Mar 24, 2026

Summary

  • Remove all console.log and console.error calls from the Storage Access API utility
  • Simplifies requestStorageAccess() while preserving the same behavior

Test plan

  • Verify iframe storage access still works in Safari/Chrome/Firefox
  • No Storage Access logs appear in browser console

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 24, 2026 8:19pm
keychain Ready Ready Preview Mar 24, 2026 8:19pm
keychain-storybook Ready Ready Preview Mar 24, 2026 8:19pm

Request Review

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 22.05%. Comparing base (08dd2d0) to head (cfd4257).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...es/keychain/src/utils/connection/storage-access.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   22.18%   22.05%   -0.13%     
==========================================
  Files         326      328       +2     
  Lines       36275    36651     +376     
  Branches     1193     1203      +10     
==========================================
+ Hits         8047     8083      +36     
- Misses      28210    28549     +339     
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@broody broody merged commit 7f5ce0c into main Mar 24, 2026
13 of 14 checks passed
@broody broody deleted the chore/remove-storage-access-logs branch March 24, 2026 20:26
@claude
Copy link
Contributor

claude bot commented Mar 24, 2026

Claude finished @broody's task —— View job


Analyzing changes for documentation impact

  • Analyze the merged changes
  • Determine if user-facing behavior changed
  • Update documentation if needed

Analysis Complete

No documentation updates needed.

This PR removed internal debug logging from packages/keychain/src/utils/connection/storage-access.ts. The changes are purely internal:

  • Function signature: Unchanged (requestStorageAccess(): Promise<boolean>)
  • Return behavior: Unchanged (returns true on success, false on error)
  • API surface: Unchanged
  • User-facing behavior: None affected

The PR description explicitly states "preserving the same behavior" and only removes console.log and console.error calls that were used for internal debugging.

Per the documentation rules: "DEFAULT TO NO CHANGES. Most code PRs do not need docs updates. Internal refactors, test changes, CI changes, and dependency bumps need nothing."

This is an internal refactor with no user-facing impact.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant