Skip to content

fix: remove feature gate for stripe checkout in starterpacks#2508

Merged
broody merged 1 commit intomainfrom
fix/remove-stripe-feature-gate
Mar 25, 2026
Merged

fix: remove feature gate for stripe checkout in starterpacks#2508
broody merged 1 commit intomainfrom
fix/remove-stripe-feature-gate

Conversation

@broody
Copy link
Contributor

@broody broody commented Mar 25, 2026

Summary

  • Stripe checkout is now always visible in the starterpack wallet selection drawer, no longer requiring the triple-click easter egg to unlock
  • Removed stripe-checkout-support from the Feature type since it's no longer used

Test plan

  • Verify Stripe Checkout option appears in wallet drawer without triple-clicking
  • Verify Stripe checkout flow works end-to-end

🤖 Generated with Claude Code

Stripe checkout is now always visible in the wallet selection drawer.
Only Coinbase (Apple Pay) remains gated behind the triple-click easter egg.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 25, 2026 6:45pm
keychain Ready Ready Preview Mar 25, 2026 6:45pm
keychain-storybook Ready Ready Preview Mar 25, 2026 6:45pm

Request Review

@claude
Copy link
Contributor

claude bot commented Mar 25, 2026

Claude finished @broody's task —— View job


Task Progress

  • Analyze the PR changes to determine if docs updates are needed
  • Search docs repository for existing Stripe/starterpack documentation
  • Make necessary documentation updates (if any)

Analysis

The PR removes a feature gate that previously hid the Stripe checkout option behind a triple-click easter egg. Now Stripe checkout is always visible in the wallet selection drawer.

Current documentation status:

  • The docs already mention Stripe/credit card payments in several places in /controller/starter-packs.md
  • Line 16: "Accept payments via credit card (Stripe)"
  • Line 120: "credit card payments are powered by Stripe"
  • Line 168-171: Lists "Credit Card: Direct fiat payment via Stripe" as a payment option with identity verification details

Key finding: The documentation never mentioned that Stripe was hidden or required a triple-click easter egg to unlock. The docs already describe Stripe as a standard payment option that's available to users.

Conclusion

No documentation updates are needed. The change simply removes an internal UI feature gate, but from the user's perspective (which is what the docs describe), Stripe has always been documented as an available payment method. The docs are already accurate for the post-merge state.

Following the rules from the direct prompt:

  1. ✅ DEFAULT TO NO CHANGES — This is an internal implementation detail that doesn't affect the documented user-facing behavior
  2. ✅ The documentation already correctly describes Stripe as an available payment option
  3. ✅ No new features or changed behavior from the user's documented perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant