Skip to content

Refine documentation of the AppTemplateValuesSource #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gberche-orange
Copy link

@gberche-orange gberche-orange commented Jan 12, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Missing CRD doc for template valuesFrom secret

image

See related slack thread https://kubernetes.slack.com/archives/CH8KCCKA5/p1673453880059389

Does this PR introduce a user-facing change?

CRD doc refines

See example secret in https://github.com/vmware-tanzu/carvel-kapp-controller/blob/ad24bdc3e41219b176f88280a469e9fd21979339/examples/simple-app-git/2.yml#L21-L31

Relates to https://github.com/vmware-tanzu/carvel/pull/613


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@neil-hickey
Copy link

hey @gberche-orange . LGTM Thanks for the update! To get this PR merged, the crds need to be regenerated 👍

Please run './hack/build.sh', './hack/gen.sh', and './hack/gen-apiserver.sh' and 'git add' the generated file(s).

@gberche-orange
Copy link
Author

thanks @neil-hickey , I've merged the doc update into #1061 as to avoid multiple crds updates and potential conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants