P2pk receive wallet by lescuer97 · Pull Request #1466 · cashubtc/cdk

lescuer97 · 2025-12-27T10:17:59Z

Description

Add public key generation with counter for wallet.

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

I followed the code style guidelines
I ran just final-check before committing

thesimplekid · 2025-12-27T22:17:06Z

This replaces this right? #1053

lescuer97 · 2025-12-29T09:17:59Z

This replaces this right? #1053

yes

lescuer97 · 2025-12-30T22:21:39Z

@thesimplekid @crodas I think this is know in a decent state. I know I'm lacking tests. I want to get your opinion on the implementation before I do that.

thesimplekid

Thanks just a few comments.

lescuer97 · 2026-01-14T13:08:44Z

@thesimplekid rebased

thesimplekid · 2026-01-15T10:02:22Z

ACK 4093b6c

thesimplekid · 2026-03-26T14:26:18Z

+
+pub use cdk_common::wallet::{WalletSaga, WalletSagaState};


Not sure why these are here?

don't know either. I remove them

thesimplekid · 2026-03-26T14:33:09Z

+
+use crate::error::Error;
+
+const CASHU_PURPOSE: u32 = 129373;


This is not the cashu purpose

Im going to change the name.

changed the name to make it clearer

thesimplekid · 2026-03-26T14:34:13Z

+const CASHU_PURPOSE: u32 = 129373;
+const P2PK_PURPOSE: u32 = 10;


Maybe should link to coco/spec of why we use these.

added some comments on why we use this. plus the PR link

thesimplekid

Didn't mean to approve. Sorry :(

thesimplekid · 2026-03-27T12:47:13Z

+    // P2PK proofs
+    /// generates and stores public key in database
+    async fn generate_public_key(&self) -> Result<PublicKey, Self::Error>;
+
+    /// gets public key by it's hex value
+    async fn get_public_key(
+        &self,
+        pubkey: &PublicKey,
+    ) -> Result<Option<P2PKSigningKey>, Self::Error>;
+
+    /// gets list of stored public keys in database
+    async fn get_public_keys(&self) -> Result<Vec<P2PKSigningKey>, Self::Error>;
+
+    /// Gets the latest generated P2PK signing key (most recently created)
+    async fn get_latest_public_key(&self) -> Result<Option<P2PKSigningKey>, Self::Error>;
+
+    /// try to get secret key from p2pk signing key in localstore
+    async fn get_signing_key(&self, pubkey: &PublicKey) -> Result<Option<SecretKey>, Self::Error>;


On second thought. And thinking about how we want to reduce our public api surface, maybe only generate and get latest should be in the public api and the other fns should be on the wallet as pub(crate) this way they can be removed from the trait and ffi?

I think the 2 that we could remove from the public are get_signing_key and get_public_keys. the others do need to there

codecov · 2026-03-27T15:02:38Z

Codecov Report

❌ Patch coverage is 24.92308% with 244 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@ba5853d). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
crates/cdk-common/src/database/wallet/test/mod.rs	0.00%	84 Missing ⚠️
crates/cdk/src/wallet/mod.rs	0.00%	45 Missing ⚠️
crates/cdk-ffi/src/database.rs	0.00%	39 Missing ⚠️
crates/cdk-ffi/src/types/wallet.rs	0.00%	19 Missing ⚠️
crates/cdk-sql-common/src/wallet/mod.rs	0.00%	16 Missing ⚠️
crates/cdk-ffi/src/wallet_trait.rs	0.00%	10 Missing ⚠️
crates/cdk-redb/src/wallet/migrations.rs	0.00%	10 Missing ⚠️
crates/cdk-redb/src/wallet/mod.rs	9.09%	10 Missing ⚠️
crates/cdk/src/wallet/wallet_trait.rs	0.00%	10 Missing ⚠️
crates/cdk/src/wallet/receive/saga/mod.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1466   +/-   ##
=======================================
  Coverage        ?   61.91%           
=======================================
  Files           ?      331           
  Lines           ?    56176           
  Branches        ?        0           
=======================================
  Hits            ?    34784           
  Misses          ?    21392           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

thesimplekid reviewed Dec 27, 2025

View reviewed changes

Comment thread crates/cdk-common/src/database/wallet/mod.rs Outdated

lescuer97 marked this pull request as ready for review December 30, 2025 22:21

thesimplekid requested changes Dec 31, 2025

View reviewed changes

thesimplekid added the wallet label Jan 1, 2026

thesimplekid added this to CDK Jan 1, 2026

github-project-automation Bot moved this to In progress in CDK Jan 1, 2026

thesimplekid reviewed Jan 1, 2026

View reviewed changes

Comment thread crates/cdk-redb/src/wallet/mod.rs Outdated

Comment thread crates/cdk/src/wallet/receive.rs Outdated

lescuer97 force-pushed the p2pk_receive_wallet branch from 0f325d8 to f1f93f3 Compare January 6, 2026 22:23

lescuer97 requested a review from thesimplekid January 8, 2026 10:49

thesimplekid reviewed Jan 8, 2026

View reviewed changes

lescuer97 force-pushed the p2pk_receive_wallet branch from cd73868 to ccaf38a Compare January 9, 2026 12:36

thesimplekid mentioned this pull request Jan 11, 2026

feat: P2PK key storage and auto-sign on receive #1053

Closed

thesimplekid added the needs rebase label Jan 11, 2026

lescuer97 force-pushed the p2pk_receive_wallet branch 3 times, most recently from af76597 to e4044ee Compare January 14, 2026 10:58

thesimplekid self-requested a review January 14, 2026 15:36

lescuer97 force-pushed the p2pk_receive_wallet branch from b64cc5d to 4093b6c Compare January 15, 2026 09:53

thesimplekid added this to the 0.15.0 milestone Jan 15, 2026

thesimplekid moved this from In progress to Ready to merge in CDK Jan 15, 2026

thesimplekid approved these changes Jan 15, 2026

View reviewed changes

thesimplekid requested changes Jan 15, 2026

View reviewed changes

Comment thread crates/cdk/src/wallet/p2pk.rs Outdated

github-project-automation Bot moved this from Ready to merge to In progress in CDK Jan 15, 2026

lescuer97 force-pushed the p2pk_receive_wallet branch 2 times, most recently from 3fccf57 to 251b0f1 Compare January 17, 2026 18:21

ye0man added nut change and removed needs rebase labels Feb 10, 2026

thesimplekid modified the milestones: 0.15.0, 0.16.0 Feb 11, 2026

lescuer97 force-pushed the p2pk_receive_wallet branch from e23f32f to 2f3829b Compare March 13, 2026 11:55

lescuer97 force-pushed the p2pk_receive_wallet branch 2 times, most recently from 52c77b3 to 30beade Compare March 20, 2026 20:15

lescuer97 mentioned this pull request Mar 20, 2026

feat: add p2pk_signing_keys to SendOptions #1750

Closed

lescuer97 added 2 commits March 25, 2026 12:53

p2pk deterministic generation

6d840d5

fmt

8dfa437

lescuer97 force-pushed the p2pk_receive_wallet branch from 30beade to 8dfa437 Compare March 25, 2026 11:58

thesimplekid mentioned this pull request Mar 26, 2026

feat(wallet): store P2PK signing keys and auto-sign on receive #1777

Closed

2 tasks

thesimplekid approved these changes Mar 26, 2026

View reviewed changes

thesimplekid requested changes Mar 26, 2026

View reviewed changes

github-project-automation Bot moved this from Ready to merge to In progress in CDK Mar 26, 2026

lescuer97 added 6 commits March 26, 2026 18:12

PR fixes

4e2a515

add wallet trait

709ab36

add functions to trait

d390d56

change how P2PK generation works

e054296

remove the public nature of P2PK

95c6baa

comment the purpose

cb9f89a

lescuer97 requested a review from thesimplekid March 26, 2026 18:10

thesimplekid requested changes Mar 27, 2026

View reviewed changes

fix pr comments

2361f07

thesimplekid approved these changes Mar 27, 2026

View reviewed changes

thesimplekid merged commit 7966d59 into cashubtc:main Mar 27, 2026
90 checks passed

github-project-automation Bot moved this from In progress to Done in CDK Mar 27, 2026

thesimplekid mentioned this pull request Mar 29, 2026

Feature request cdk-wallet: store P2PK key and lookup automatically on token receive #1029

Closed

crodas pushed a commit to crodas/cdk that referenced this pull request May 19, 2026

feat: add p2pk key generation and storage to wallet (cashubtc#1466)

21f7d0a

		const CASHU_PURPOSE: u32 = 129373;
		const P2PK_PURPOSE: u32 = 10;

Conversation

lescuer97 commented Dec 27, 2025

Description

Notes to the reviewers

Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED

Checklist

Uh oh!

thesimplekid commented Dec 27, 2025

Uh oh!

Uh oh!

lescuer97 commented Dec 29, 2025

Uh oh!

lescuer97 commented Dec 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thesimplekid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lescuer97 commented Jan 14, 2026

Uh oh!

thesimplekid commented Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lescuer97 Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thesimplekid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 27, 2026

Codecov Report

Uh oh!

lescuer97 Mar 26, 2026 •

edited

Loading