Tharp/macvo fix #222
Closed
Tharp/macvo fix #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Title
What does this pull request do?
This edit fixes the frame issue that caused MACVO to not follow the drone properly.
Which issue number does this address?
Issue #75
Add videos and images if possible.
How did you implement it?
The MACVO node now has a correction that is applied to the pose output from MACVO to transform that into the native robot coordinate frame.
Testing
How do you run the tests?
What do the tests do?
What are the expected results of the tests?
Did you update the docs (and where)?
Docs are updated via mkdocs.yml and markdown files under
docs/. It should render at localhost:8000 when you rundocker compose up docs.