Skip to content

Comments

build: fix cmake builds not working on windows#8069

Open
scarf005 wants to merge 2 commits intocataclysmbn:mainfrom
scarf005:build/visual-studio-cmake-gettext
Open

build: fix cmake builds not working on windows#8069
scarf005 wants to merge 2 commits intocataclysmbn:mainfrom
scarf005:build/visual-studio-cmake-gettext

Conversation

@scarf005
Copy link
Member

@scarf005 scarf005 commented Feb 8, 2026

Purpose of change (The Why)

Describe the solution (The How)

can't just install gettext with vcpkg because of microsoft/vcpkg#8272
uses pre-compiled binaries from https://github.com/mlocati/gettext-iconv-windows instead

Testing

vlcsnap-2026-02-08-11h57m12s415

worked on VM

2026-02-08_10-51-10.mp4

@scarf005 scarf005 enabled auto-merge (squash) February 8, 2026 03:05
@AzmodiusX
Copy link
Collaborator

I still get errors for the json formatter if I don't set the generator to Ninja.
Disabling that just has another error, and so on.
Any reason we don't just use the Ninja generator?

@AzmodiusX
Copy link
Collaborator

Additionally, I had to re-do many cmake setup steps, so this likely won't be drag and drop for current windows devs.
Should be fine though, the actual steps aren't complex.

@AzmodiusX
Copy link
Collaborator

AzmodiusX commented Feb 8, 2026

You know, I think my setup is reverse broken.
I managed to make everything work without this PR (or Ninja).
If I test again, I'm also using a VM.
Edit: or not
I hate windows too friend

Ok, so as not to spam, edit:
It now compiles without this PR, but requires Ninja generator
But only after the cmake command is run with Visual Studio 17 2022 as the generator (maybe?)
I am hate

@chaosvolt chaosvolt disabled auto-merge February 8, 2026 22:53
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above issues should be addressed before it's ready for merging.

@AzmodiusX
Copy link
Collaborator

Assuming they exist and that my windows install isn't somehow more cursed than yours.

@scarf005 scarf005 force-pushed the build/visual-studio-cmake-gettext branch from 3e01049 to 2b369f3 Compare February 15, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants