Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #136: Missing implementation of core_userlist_provider #1

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

agaranin
Copy link
Collaborator

@agaranin agaranin commented Dec 6, 2024

Fix for Missing Implementation of core_userlist_provider and Metadata Test Failures

Issue KQMATH#136: Missing Implementation of core_userlist_provider

The Privacy API provider class for mod_jazzquiz did not implement the core_userlist_provider interface, causing unit test failures.
Added the required methods:
get_users_in_context(userlist $userlist)
delete_data_for_users(userlist $userlist)
These methods now correctly handle user data associated with the plugin's context.
Fix for Metadata Test Failures

Another test failure was identified related to missing metadata for the jazzquiz_attendance table.
The table jazzquiz_attendance contains the userid field, which was not declared in the get_metadata() method of the Privacy API provider.
Metadata for this table has been added, ensuring compliance with Privacy API requirements.

@niko-hoogeveen niko-hoogeveen merged commit 3b42a94 into release/1.2-catalyst Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants