Merge CacheNode and Node back to single class #1825
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove using next pointers in rodb cache, always use cache, since using a shared ptr can keep nodes that should be recycled.
Chen-Yifan
reviewed
Nov 3, 2025
| else { | ||
| traverse_sender.traverse_root = | ||
| copy_node<Node>(res.assume_value().get()); | ||
| copy_node(res.assume_value().get()); |
Contributor
There was a problem hiding this comment.
no longer need copy_node() here, since the find result type now matches what traverse_root expects. There are some in other test files that we can remove too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove using next pointers in rodb cache, always use hash, since using a shared ptr can keep nodes that should be recycled.