Make PM submit tolerate assignment replica lag#296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pm-*challenge id whenper_miner_assignmentsis not visible yet.pm-*challenge ids rejected.Why
Miners were intermittently seeing
assignment_required_fetch_challenges_firstimmediately after fetching a private CNF. Root cause:/per-miner/cnfwroteper_miner_assignments, but immediate/v1/agents/submitcould read from a lagging replica/app state and miss the row.Verification
UV_LINK_MODE=copy uv run --extra publisher python publisher_verify.py-> PASS all 149 checksUV_LINK_MODE=copy uv run --extra publisher python assigned_lane_verify.py-> PASS all 15 checksUV_LINK_MODE=copy uv run --extra publisher python weights_verify.py-> PASS all 32 checksUV_LINK_MODE=copy uv run --extra publisher python -m compileall scaffold publisher_verify.py assigned_lane_verify.py weights_verify.py-> PASSgit diff --check-> PASSLaunch Note
This is safe to deploy independently. It does not change scoring math. It only removes a false-negative PM submit rejection caused by assignment-ledger visibility lag.