feat: Implement deposit_fiat and withdraw_fiat Functions for Fiat Tr…#11
Merged
caxtonacollins merged 2 commits intocaxtonacollins:mainfrom Jun 9, 2025
Olowodarey:deposit
Merged
feat: Implement deposit_fiat and withdraw_fiat Functions for Fiat Tr…#11caxtonacollins merged 2 commits intocaxtonacollins:mainfrom Olowodarey:deposit
caxtonacollins merged 2 commits intocaxtonacollins:mainfrom
Olowodarey:deposit
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Fiat Deposit and Withdrawal Functionality
Description
This PR implements fiat currency deposit and withdrawal functionality in the Account contract, including comprehensive test coverage.
Changes
deposit_fiatandwithdraw_fiatfunctions to handle fiat currency operationsTest Coverage
test_deposit_fiat: Verifies basic deposit functionalitytest_withdraw_fiat_insufficient_balance: Ensures withdrawals can't exceed balancetest_multiple_deposits: Tests multiple deposits to the same currencytest_different_currencies: Verifies isolation between different currency balancestest_deposit_zero_amount: Validates zero-amount deposit preventionSecurity Considerations
assert_only_self()Notes
u128for amounts to support large valuesfelt252for flexibilitycloses #3