Feat: implement up-gradable and access control #5
Merged
caxtonacollins merged 2 commits intocaxtonacollins:mainfrom May 29, 2025
Olowodarey:acoount
Merged
Feat: implement up-gradable and access control #5caxtonacollins merged 2 commits intocaxtonacollins:mainfrom Olowodarey:acoount
caxtonacollins merged 2 commits intocaxtonacollins:mainfrom
Olowodarey:acoount
Conversation
Owner
|
@Olowodarey, please integrate the SNIP9 OutsideExecution component from OZ. |
Owner
caxtonacollins
left a comment
There was a problem hiding this comment.
i have made some reviews that will close this pr, pls make the changes, run scarb fmt, scarb build and scarb test, before pushing.
Owner
There was a problem hiding this comment.
please add this to storage:
// Custom storage for SyncPayment functionality
fiat_balance: Map<(ContractAddress, felt252), u128>, // (user, currency) => balance
token_address: Map<felt252, ContractAddress>, // symbol => token_address
default_fiat_currency: felt252,
liquidity_bridge: ContractAddress,
initialized: bool,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accountcontract.AccessControlfor role-based permission management.only_owner(or relevant role modifier).Test Coverage: