Skip to content

Fix deprecation on sf6/sf7 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecation on sf6/sf7 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Symfony Bundle for [caxy/php-htmldiff][0].

## Requirements

- PHP 5.3.3 or higher
- PHP 7.1 or higher
- [caxy/php-htmldiff][0]

## Installation
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
}
],
"require": {
"php": ">=7.0",
"symfony/framework-bundle": "~2.3||3.*||4.*||5.*||6.*",
"php": ">=7.1",
"symfony/framework-bundle": "4.*||5.*||6.*||7.*",
"caxy/php-htmldiff": "~0.1"
},
"require-dev": {
Expand Down
6 changes: 3 additions & 3 deletions src/DependencyInjection/CaxyHtmlDiffExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function __construct()
/**
* {@inheritDoc}
*/
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);
Expand All @@ -63,7 +63,7 @@ public function load(array $configs, ContainerBuilder $container)
* @param ContainerBuilder $container
* @param string $cacheDriverId
*/
protected function loadHtmlDiffConfig(array $config, ContainerBuilder $container, $cacheDriverId = null)
protected function loadHtmlDiffConfig(array $config, ContainerBuilder $container, $cacheDriverId = null): void
{
$loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
$loader->load('services.yml');
Expand Down Expand Up @@ -100,7 +100,7 @@ protected function loadHtmlDiffConfig(array $config, ContainerBuilder $container
* @return string
* @throws \Exception
*/
protected function loadCacheDriver($cacheName, array $driverMap, ContainerBuilder $container)
protected function loadCacheDriver($cacheName, array $driverMap, ContainerBuilder $container): string
{
if (null === $this->cacheProviderLoader) {
throw new \Exception('DoctrineCacheBundle required to use doctrine_cache_driver.');
Expand Down