Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings due to undeclared features "libfuse2", "libfuse3" #311

Closed
dannycjones opened this issue Nov 6, 2024 · 0 comments · Fixed by #313
Closed

Build warnings due to undeclared features "libfuse2", "libfuse3" #311

dannycjones opened this issue Nov 6, 2024 · 0 comments · Fixed by #313

Comments

@dannycjones
Copy link
Contributor

dannycjones commented Nov 6, 2024

Hey! We currently maintain a forked version of fuser for our own use and are building on newer Rust versions (1.82).

From Rust v1.80, cfg values will be checked to ensure they match all known possible values. https://blog.rust-lang.org/2024/05/06/check-cfg.html

Fuser makes use of the features libfuse2 and libfuse3 when conditionally compiling code for each implementation of libfuse. This leads to a lot of warnings when building with newer versions of Rust.

I'd like to propose that we move this conditional logic to be a new cfg values (not feature) which we can declare so that Rust is aware of the possible values. Alternatively, the 'easy' option is to just declare libfuse2 and libfuse3 as features however this doesn't seem right, as these aren't meant to be customer-facing features.

I've created pull request #313 that implements this change, however I'm open to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant