Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace features libfuse2,libfuse3 with a dedicated build cfg value #313

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

dannycjones
Copy link
Contributor

@dannycjones dannycjones commented Nov 6, 2024

From Rust v1.80, cfg values will be checked to ensure they match all known possible values. https://blog.rust-lang.org/2024/05/06/check-cfg.html

fuser makes use of the features libfuse2 and libfuse3 when conditionally compiling code for each implementation of libfuse. This leads to a lot of warnings when building fuser with newer versions of Rust (v1.80+).

This change moves this conditional logic to be a new dedicated cfg field (not features) which are declared so that Rust is aware of the possible values.

An alternative to this would be to just declare libfuse2 and libfuse3 as features however this doesn't seem right, as these aren't meant to be customer-facing features.

This change was originally proposed in #311.

Fixes #311

@cberner cberner merged commit 9f6ced7 into cberner:master Nov 8, 2024
9 checks passed
@cberner
Copy link
Owner

cberner commented Nov 8, 2024

Thanks!

@dannycjones dannycjones deleted the add-cfg-for-mount-impl branch November 8, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build warnings due to undeclared features "libfuse2", "libfuse3"
2 participants