Use checked arithmetic for addition to Unix epoch. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code can panic with filesystems that do not store times. Using checked arithmetic allows such filesystems to operate without panic.
|
I'm not sure this is the right fix. That code path is only taken when the appropriate |
|
This is happening (at least for me on macOS) when sending I wonder if this is also related to #217? |
cloud-fs
added a commit
to cloud-fs/fuser
that referenced
this pull request
Apr 11, 2023
|
Hello, I'm having an issue that would be solved by this PR. I've done some investigation and I think the issue lies on @cberner, could this PR be merged ? Or does it require additional work ?
|
|
Going to close this in favor of #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code can panic with filesystems that do not store times. Using checked arithmetic allows such filesystems to operate without panic.