Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci cache concurrency issue #323

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

FirelightFlagboy
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy commented Nov 27, 2024

Using the same cache key across multiple jobs can cause issues if we make assumption about it's content (like installing tools if not hit on the cache).

That cache was also forgetting caching rustup folder

@FirelightFlagboy FirelightFlagboy force-pushed the fix-ci branch 3 times, most recently from 08b8296 to c83bc51 Compare November 27, 2024 15:38
@FirelightFlagboy FirelightFlagboy changed the title Fix cache concurrency issue Fix ci cache concurrency issue Nov 27, 2024
@FirelightFlagboy FirelightFlagboy marked this pull request as ready for review November 27, 2024 15:39
@cberner
Copy link
Owner

cberner commented Nov 27, 2024

Did you intend to include the MD file? Looks like that's meant to be filed as an Issue?

@FirelightFlagboy
Copy link
Contributor Author

Did you intend to include the MD file? Looks like that's meant to be filed as an Issue?

No 😅

Using the same cache key across multiple jobs can cause issues if we make assumption about it's content (like installing tools if not hit on the cache).
@cberner cberner merged commit 998bb95 into cberner:master Nov 27, 2024
9 checks passed
@cberner
Copy link
Owner

cberner commented Nov 27, 2024

Thanks!

@FirelightFlagboy FirelightFlagboy deleted the fix-ci branch November 28, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants