add js, wasm, macos targets and a test#14
Merged
Merged
Conversation
sargunv
commented
Jun 16, 2025
cbeyls
approved these changes
Jun 16, 2025
cbeyls
left a comment
cbeyls
left a comment
Owner
There was a problem hiding this comment.
Looks good to me, thank you very much for your contribution !
Owner
|
Sorry for the delay, the new release is now available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated KtXml to the new version that supports all Kotlin Multiplatform targets, and added all targets that were missing here that Compose UI builds for. Will solve #13 when published.
Also added a unit test and a job to run it in CI on all platforms, to show it's working.
I didn't add these to the sample app, as you said you'd prefer to focus on stable plaforms. But I'd be happy to add them to the sample if requested.