A rough pass at cutting initial bundle up into dynamic loadable route…#9
Open
butlersrepos wants to merge 1 commit intocbonoz:masterfrom
Open
A rough pass at cutting initial bundle up into dynamic loadable route…#9butlersrepos wants to merge 1 commit intocbonoz:masterfrom
butlersrepos wants to merge 1 commit intocbonoz:masterfrom
Conversation
…s, removed or split some large dependencies. Little done with regards to actual app rendering yet.
Author
|
"wants to merge" is strong language, just creating a PR for visibility 👍 |
Author
|
Code split bundles after these changes.
Future targets: Defer loading of youtube js (400kb), optimize css add-ins by trimming unneeded bootstrap and font-awesome source, Current bundle analysis - https://atom-subway.glitch.me/ |
Owner
|
Hey, thanks for the PR @butlersrepos . You familiar with the create-react-app framework? Would be cool if we could optimize this without having to eject the project defaults, but I'm open to other suggestion if you have it as well. Looks promising. |
Author
|
I don't think I needed to eject for any particular reason actually... I
went that way right out of the gates to make sure I could analyze the
bundle but the source map explorer should work fine with create react app
shell
…On Wed, Feb 28, 2018, 9:20 PM Chris Buonocore ***@***.***> wrote:
Hey, thanks for the PR butlers. You familiar with the create-react-app
framework? Would be cool if we could optimize this without having to eject
the project defaults, but I'm open to other suggestion if you have it as
well.
Looks promising.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABURG6n6xsL0EGXAOLCIAKsSElcL5kDRks5tZ4UugaJpZM4SXwrS>
.
|
Owner
Author
|
I don't recall what `react-scripts` are composed of, but eject removes
react-scripts in lieu of the equivalent webpack, babel, etc.
…On Thu, Mar 1, 2018 at 4:50 PM, Chris Buonocore ***@***.***> wrote:
Eject is required to modify these webpack scripts no? Otherwise I believe yarn
build (which runs react-scripts) would run these instead.
[image: image]
<https://user-images.githubusercontent.com/2351087/36877760-cf779948-1d89-11e8-95fb-fe26c9456133.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABURGwo2LdFziSFu7Ty6sd0lNCY9Dq2cks5taJddgaJpZM4SXwrS>
.
--
Eric Butler
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


…s, removed or split some large dependencies. Little done with regards to actual app rendering yet.