Featureclasses - #145
Open
Rkleisley wants to merge 32 commits into
Open
Conversation
added from_featureclass
to_featureclass
added internal function to convert timestamp columns
Function to parse a featureclass using arcgis package
Added function to parse featureclasses using arcpy
converts a featureclass to a Track or FeatureCollection by creating a Spatial Enabled DataFrame (SEDF) and parsing it into GeoShapes
method to convert a feature class to Track or FeatureCollection using arcpy SearchCursor and featureclass parser
ccbest
requested changes
Oct 20, 2024
ccbest
left a comment
ccbest
left a comment
Owner
There was a problem hiding this comment.
Couple quick changes then good to go - let's talk Monday
| TimeInterval: The time interval representing the start and end time. | ||
| """ | ||
| import pandas as pd | ||
| from geostructures.time import TimeInterval |
| import pandas as pd | ||
| from geostructures.time import TimeInterval | ||
|
|
||
| if pd.notnull(start_time) or pd.notnull(end_time): |
Owner
There was a problem hiding this comment.
let's take a quick re-look at this block. If start_time/end_time is not null but is also not a timestamp it could cause issues
| features=[x.to_fastkml_placemark() for x in self.geoshapes] | ||
| ) | ||
|
|
||
| def to_featureclass(self, geodatabase, filename): |
| } | ||
|
|
||
|
|
||
| def _get_datetime_pandas(start_time, end_time): |
Owner
There was a problem hiding this comment.
_PARSER_MAP not updated with new types that can show up
|
|
||
| if geometry_type_str == 'POINT': | ||
| lon, lat = geometry.x, geometry.y | ||
| shape = parser(Coordinate(lon, lat), properties=properties) |
Owner
There was a problem hiding this comment.
It looks like you're using __init__ - let's talk about this, I think we can simplify things a little
from_featureclass added to GeoLineString, GeoPoint, and GeoPolygon
from_arcgis_featureclass and from_arcpy_featureclass methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsers for feature classes and methods for feature class to Track / FeatureCollection