Skip to content

Refactor protobuf messages #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor protobuf messages #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 44 additions & 6 deletions certifier_service/certprotos/certifier.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,15 +247,53 @@ message proof {
repeated proof_step steps = 3;
};

// submitted_evidence_type is "full-vse-support"
// "platform-attestation-only" or "oe-evidence"
// or "asylo-evidence"
message vse_package {
optional bytes claim = 1;
optional bytes attestation = 2;
};

message gramine_package {
optional bytes platform_cert = 1;
optional bytes attestation = 2;
}

message keystone_package {
optional bytes attestation = 1;
};

message islet_package {
optional bytes attestation = 1;
};

message sev_package {
optional bytes ark = 1;
optional bytes ask = 2;
optional bytes vcek = 3;
optional bytes attestation = 4;
};

message oe_package {
optional bytes cert_chain = 1;
optional bytes attestation = 2;
};

enum msg_purpose {
authentication = 0;
attestation = 1;
};

message trust_request_message {
optional string requesting_enclave_tag = 1;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this and the next one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

optional string providing_enclave_tag = 2;
optional string submitted_evidence_type = 3;
optional string purpose = 4; // "authentication" or "attestation"
optional evidence_package support = 5;
optional msg_purpose purpose = 3;
oneof evidence_package {
vse_package vse_pkg = 4;
gramine_package gramine_pkg = 5;
keystone_package keystone_pkg = 6;
islet_package islet_pkg = 7;
sev_package sev_pkg = 8;
oe_package oe_pkg = 9;
}
};

message trust_response_message {
Expand Down
5 changes: 0 additions & 5 deletions include/cc_helpers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,6 @@
bool open_client_socket(const string &host_name, int port, int *soc);
bool open_server_socket(const string &host_name, int port, int *soc);

bool construct_platform_evidence_package(string & enclave_type,
const string & purpose,
evidence_list & list,
string & the_attestation,
evidence_package *ep);
bool add_policy_key_says_platform_key_is_trusted(
signed_claim_message &platform_key_is_trusted,
evidence_package * ep);
Expand Down
Loading