Fix ssh-agent shutdown on terminal close #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python 3.2 the default value for close_fds changed from True to False. Therefore ssh-agent inherits the file descriptors to /dev/tty from ssh-ident. At least on Cygwin this causes ssh-agent to shut down when the terminal is closed. Signed-off-by: Konrad Gräfe <[email protected]>
kgraefe
force-pushed
the
fix-ssh-agent-shutdown-on-terminal-close
branch
from
17becaa to
3a383df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python 3.2 the default value for
close_fdschanged fromTruetoFalse. Therefore ssh-agent inherits the file descriptors to/dev/ttyfrom ssh-ident. At least on Cygwin this causes ssh-agent to shut down
when the terminal is closed.