Skip to content

fix: add to_plain_md by datajson.py & unit#550

Merged
drunkpig merged 3 commits intoccprocessor:devfrom
renpengli01:rpl01
Sep 10, 2025
Merged

fix: add to_plain_md by datajson.py & unit#550
drunkpig merged 3 commits intoccprocessor:devfrom
renpengli01:rpl01

Conversation

@renpengli01
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #550      +/-   ##
==========================================
+ Coverage   90.97%   91.02%   +0.04%     
==========================================
  Files         102      106       +4     
  Lines        8890     9173     +283     
==========================================
+ Hits         8088     8350     +262     
- Misses        802      823      +21     
Files with missing lines Coverage Δ
llm_web_kit/input/datajson.py 85.78% <100.00%> (+1.09%) ⬆️
llm_web_kit/libs/doc_element_type.py 100.00% <100.00%> (ø)
llm_web_kit/simple.py 89.15% <100.00%> (-7.67%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclude_inline_types应该包含 行内公式和行内代码

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIDEO, AUDIO也应该在内

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个测试用例应当包含我说的那2个case.
从原始的html来时输出。html放到文件里,容易维护。这个html可以手工构造的。包含以上各种元素。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种写法不易维护,字符串坨在一起

@drunkpig drunkpig merged commit ada427b into ccprocessor:dev Sep 10, 2025
4 checks passed
@renpengli01 renpengli01 deleted the rpl01 branch September 17, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants