Add panels layout component #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njbriggs
approved these changes
Jan 3, 2025
| */ | ||
|
|
||
| export function sleep(durationInMs: number): Promise<void> { | ||
| return new Promise((resolve) => setTimeout(resolve, durationInMs)); |
There was a problem hiding this comment.
As noted in the other PR, please rename this to delay or similar.
radhikav1
approved these changes
Jan 7, 2025
GnsP
force-pushed
the
add-panels-component
branch
from
ccda48a to
bc492f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add panels layout component
Description
Adds a component to conveniently manage screen layouts with multiple panels.
left,top,rightandbottom.Attached is a screen recoding of a demo page using this component.
PR Type
Links
Jira: Jira issue #
Test Plan
TBD
Screenshots
Screen.Recording.2024-11-08.at.11.27.36.AM.mov