Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN-1771] Add Streaming support for excel source #1847

Merged

Conversation

psainics
Copy link
Contributor

@psainics psainics commented Mar 21, 2024

Add Streaming support for excel source

Jira : PLUGIN-1771

Description

Excel plugin consumes huge memory when reading large files.
This is due to it loading the complete file in it's memory.

This PR adds streaming support xlxs filetype.

  • As we won't be able to stream old xls binary based format we use magic bytes to detect the filetype.

UI Field

  • No Changes made to widget json.

Docs

  • No Changes made to docs.

Code change

  • Modified ExcelInputFormat.java

Unit Tests

  • No Changes made to unit tests.

@bharatgulati bharatgulati added the build Trigger unit test build label Mar 21, 2024
Copy link
Member

@fernst fernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add some tests for file reads? Just create some dummy xls/xlsx files, read and ensure output matches input.

@psainics
Copy link
Contributor Author

This has been tested by QA!
We need to release in this CDF version so we are merging this PR as is, will raise a new PR adding test for reading dummy files !

@vikasrathee-cs vikasrathee-cs merged commit bf191b5 into cdapio:develop Mar 29, 2024
7 checks passed
@psainics psainics deleted the patch/update-poi-api-excel-input branch February 16, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Trigger unit test build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants