feat(aspect): sagemaker-automated-shutdown #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrike
reviewed
Mar 24, 2025
| stack: Stack | ||
| ): void { | ||
| const lifecycleConfig = this.createLifecycleConfig(instance, stack); | ||
| instance.lifecycleConfigName = lifecycleConfig.ref; |
There was a problem hiding this comment.
This will overwrite the existing lifecycle config if there is one right? Is there a way to append to an existing lifecycle script if the user has already defined one? I didn't try this when we used this before but if we can't, we need to define a clear docstring that tells the user that this will overwrite any existing lifecycle configuration policy they've defined
derrike
reviewed
Mar 24, 2025
| } | ||
|
|
||
| export class SageMakerAutomatedShutdown implements IAspect { | ||
| private processedInstances: Set<string> = new Set(); |
There was a problem hiding this comment.
Do we need to do this for this Aspect?
derrike
reviewed
Mar 25, 2025
| @@ -0,0 +1,152 @@ | |||
| import requests | |||
There was a problem hiding this comment.
Can we put this file in a scripts directory in this folder
* vitest * chore: replace jest with vitest * fix from rebase * add reference type * yarn lock * try dependency fix * fix .only modifier * try removing from main deps * remove deps2 * try removing dep resolutions * try deps again * remove more resolutions * back to no resolutions * vitest compat1 * vitest compat2 * vitest compat3 * vitest compat 4 * final vitest compat * add watch w/ no cov * silent mode by default * remove jest types
…ic Hosting pattern (cdklabs#96)
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/cdklabs/cdk-proserve-lib/actions/runs/14048726094 ------ *Automatically created by projen via the "upgrade-dev-deps-main" workflow* Signed-off-by: github-actions <[email protected]> Co-authored-by: github-actions <[email protected]>
auto-merge was automatically disabled
March 25, 2025 16:06
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in aspect for an automated shutdown mechanism for SageMaker Notebook Instances. Provides configurable Idle Timeout Time as metric used to determine what instances should be shutdown.