adds FFI Tests - #320
Conversation
519189a to
fbe42ef
Compare
| result | ||
| ); | ||
|
|
||
| let jval = result.unwrap(); |
There was a problem hiding this comment.
Nit: variable naming can be improved here
There was a problem hiding this comment.
I updated it and made the names more detailed not 100% sure if its how you guys want it tho
fbe42ef to
b322546
Compare
| use jni::JavaVM; | ||
| use std::sync::LazyLock; | ||
|
|
||
| // Static JVM to be used by all the tests. LazyLock for thread-safe lazy initialization |
There was a problem hiding this comment.
I find the comment helpful imo! But fine either way
There was a problem hiding this comment.
Yeah, we can add this comment and remove the following comment from interface.rs
///
///
/// REPO MADE FOR TESTS OF NON-REFACTORED METHODS
///
///
+ need to run cargo fmt as formatting tests are failing.
Rest looks good to me.
| "User": { | ||
| "memberOfTypes": ["Group"] | ||
| }, | ||
| "Group": {}, | ||
| "File": {} | ||
| }, | ||
| "actions": { | ||
| "read": { | ||
| "appliesTo": { | ||
| "principalTypes": ["User"], | ||
| "resourceTypes": ["File"] | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: if there's another commit coming on this PR, could consider fixing the indentation here and elsewhere while you're at it
There was a problem hiding this comment.
will be looking over the schemas
Signed-off-by: Raheim Swaby <swabyra@amazon.com>
b322546 to
b6cf365
Compare
mark-creamer-amazon
left a comment
mark-creamer-amazon
left a comment
There was a problem hiding this comment.
Looks good to me!
3 participants
Issue #, if available:
Tests for non refactored methods along with some tests cases I had written for JLIST.RS over the weekend.
Description of changes: