make symcc fuzz targets use linked policies - #948
Draft
victornicolet wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Victor Nicolet <victornl@amazon.com>
4 tasks
| for p in policies { | ||
| let single = p.into_policy_set(); | ||
| for policy in single.policies() { | ||
| ps.add(policy.clone()).unwrap_or(()); |
Contributor
There was a problem hiding this comment.
probably don't want to ignore errors here
Specifically, this might be silently ignoring template links since PolicySet::add errors on non-static policies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make symcc fuzz targets use the
ABACPoliciesinstead of theStatic-version.The corresponding PR on the cedar repo is cedar-policy/cedar#2338
Ran the DRT for ~1 hour on 4 of the targets without issues.