Skip to content

better equality check for entity in protobuf decodes prop #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victornicolet wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

better equality check for entity in protobuf decodes prop #996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cedar-drt/fuzz/src/props.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,12 @@ pub fn schema_to_cedar_parses(schema: &Schema) -> Schema {
/// indicate a bug.
pub fn entity_protobuf_decodes(buf: &[u8], original: &Entity) {
match Entity::decode(buf) {
Ok(decoded) => assert_eq!(*original, decoded),
Ok(decoded) => pretty_assert_entities_deep_eq(
&Entities::from_entities([original.clone()], None)
.expect("failed to create entities from single entity"),
&Entities::from_entities([decoded], None)
.expect("failed to create entities from single entity"),
),
// we expect conversion errors here: the entity has not been validated first, we only
// test that the protobuf decoding part works, not the conversion
Err(DecodeError::Conversion(_)) => (),
Expand Down