Skip to content

ignore loc in Ord just like in PartialOrd - #2496

Open
victornicolet wants to merge 1 commit into
mainfrom
victornicolet/entity-ignore-loc-in-ord-educe
Open

ignore loc in Ord just like in PartialOrd#2496
victornicolet wants to merge 1 commit into
mainfrom
victornicolet/entity-ignore-loc-in-ord-educe

Conversation

@victornicolet

Copy link
Copy Markdown
Member

Also ignore log in Ord, just like for PartialOrd on EntityUIDImpl.

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-docs. PRs should be targeted at a staging-X.Y branch, not main.)
  • I'm not sure how my change impacts the documentation. (Post your PR anyways, and we'll discuss in the comments.)

Signed-off-by: Victor Nicolet <victornl@amazon.com>
#[educe(PartialEq(ignore))]
#[educe(Hash(ignore))]
#[educe(PartialOrd(ignore))]
#[educe(Ord(ignore))]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

Copy link
Copy Markdown

Coverage Report

Head Commit: 9096430d9067d3993117ff4cfd38a422e1934b18

Base Commit: d03f6dd9a818635479a8fd14806bb5ad9dfc8bf4

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 100.00%

Status: PASSED ✅

Details
File Status Covered Coverage Missed Lines

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 88.38%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-language-server 🟢 4722/5102 92.55% 92.55%
cedar-policy 🟢 4834/5940 81.38% 81.38%
cedar-policy-cli 🟡 1294/1669 77.53% 77.53%
cedar-policy-core 🟢 24670/27826 88.66% 88.66%
cedar-policy-formatter 🟢 914/1088 84.01% 84.01%
cedar-policy-symcc 🟢 6916/7396 93.51% 93.51%
cedar-wasm 🔴 0/28 0.00% 0.00%

@john-h-kastner-aws john-h-kastner-aws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change is good either way, but we should understand what educe changed given prior issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants