Skip to content

TPE: reduce has/hasTag/==/in/is using schema type information - #2503

Open
john-h-kastner-aws wants to merge 2 commits into
mainfrom
tpe-reduce-has-hastag-false
Open

TPE: reduce has/hasTag/==/in/is using schema type information#2503
john-h-kastner-aws wants to merge 2 commits into
mainfrom
tpe-reduce-has-hastag-false

Conversation

@john-h-kastner-aws

Copy link
Copy Markdown
Contributor

Description of changes

Fixes #2500

Lean model and proofs in cedar-policy/cedar-spec#997

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

I confirm that docs.cedarpolicy.com (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar language specification.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-docs. PRs should be targeted at a staging-X.Y branch, not main.)
  • I'm not sure how my change impacts the documentation. (Post your PR anyways, and we'll discuss in the comments.)

Signed-off-by: jkastner <jkastner@amazon.com>
@john-h-kastner-aws
john-h-kastner-aws requested a review from luxas July 29, 2026 19:45
@github-actions

Copy link
Copy Markdown

Coverage Report

Head Commit: 1122502d04b7c6113ea4a4f609e7e064c8f70c0d

Base Commit: 64c925c4a9760a4f8bfdd4814e3b02371b57292a

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 96.00%

Status: PASSED ✅

Details
File Status Covered Coverage Missed Lines
cedar-policy-core/src/batched_evaluator.rs 🟢 2/2 100.00%
cedar-policy-core/src/tpe.rs 🟢 1/1 100.00%
cedar-policy-core/src/tpe/evaluator.rs 🟢 23/25 92.00% 223, 262
cedar-policy-core/src/validator/schema.rs 🟢 16/16 100.00%
cedar-policy-core/src/validator/typecheck.rs 🟢 6/6 100.00%
cedar-policy-core/src/validator/types.rs 🟢 24/25 96.00% 506

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 88.38%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-language-server 🟢 4722/5102 92.55% --
cedar-policy 🟢 4844/5950 81.41% --
cedar-policy-cli 🟡 1294/1669 77.53% --
cedar-policy-core 🟢 24703/27865 88.65% --
cedar-policy-formatter 🟢 914/1088 84.01% --
cedar-policy-symcc 🟢 6916/7396 93.51% --
cedar-wasm 🔴 0/28 0.00% --

Signed-off-by: jkastner <jkastner@amazon.com>
@github-actions

Copy link
Copy Markdown

Coverage Report

Head Commit: 2b7972d83a9b79ee38d978c9cb3a8a4c19488041

Base Commit: 64c925c4a9760a4f8bfdd4814e3b02371b57292a

Download the full coverage report.

Coverage of Added or Modified Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 96.00%

Status: PASSED ✅

Details
File Status Covered Coverage Missed Lines
cedar-policy-core/src/batched_evaluator.rs 🟢 2/2 100.00%
cedar-policy-core/src/tpe.rs 🟢 1/1 100.00%
cedar-policy-core/src/tpe/evaluator.rs 🟢 23/25 92.00% 223, 262
cedar-policy-core/src/validator/schema.rs 🟢 16/16 100.00%
cedar-policy-core/src/validator/typecheck.rs 🟢 6/6 100.00%
cedar-policy-core/src/validator/types.rs 🟢 24/25 96.00% 506

Coverage of All Lines of Rust Code

Required coverage: 80.00%

Actual coverage: 88.39%

Status: PASSED ✅

Details
Package Status Covered Coverage Base Coverage
cedar-language-server 🟢 4722/5102 92.55% --
cedar-policy 🟢 4844/5950 81.41% --
cedar-policy-cli 🟡 1294/1669 77.53% --
cedar-policy-core 🟢 24706/27865 88.66% --
cedar-policy-formatter 🟢 914/1088 84.01% --
cedar-policy-symcc 🟢 6916/7396 93.51% --
cedar-wasm 🔴 0/28 0.00% --

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TPE Fails to Eliminate Irrelevant Policies

1 participant