feat: #240 Contract: Implement TWAP for reliable oracle pricing#311
Open
Chinonso-Peter wants to merge 1 commit intoceejaylaboratory:mainfrom
Open
feat: #240 Contract: Implement TWAP for reliable oracle pricing#311Chinonso-Peter wants to merge 1 commit intoceejaylaboratory:mainfrom
Chinonso-Peter wants to merge 1 commit intoceejaylaboratory:mainfrom
Conversation
|
@Chinonso-Peter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented #240 in src/oracle_consumer/lib.rs (line 1) and added .codex to .gitignore (line 28).
The oracle consumer now keeps a bounded per-asset observation history, computes a real time-weighted average price over a configurable lookback window, rejects stale data, and requires history that actually covers the requested TWAP window so a fresh flash-loan-distorted spot update can’t dominate the returned price. The default get_price(asset) path now returns TWAP instead of the latest spot price, and admin setters were added for the TWAP window, max price age, and retained observation count.
I also added unit tests covering initialization, spot updates, bounded history, full-window coverage requirements, and the key manipulation-resistance behavior where a late spike only slightly moves the reported price instead of replacing it.
Verification passed with an isolated crate test run:
cargo test --manifest-path /tmp/oracle_consumer_check/Cargo.toml
closes #240