Skip to content

Conversation

@rahulbile
Copy link
Contributor

No description provided.

@rahulbile
Copy link
Contributor Author

rahulbile commented Dec 12, 2018

@mrfelton can you please review this PR? This updates the API version to latest and adds new method to pause and resume subscription.

@rahulbile rahulbile force-pushed the rb/recurly-pause-resume branch from 758df16 to 96ab55b Compare December 12, 2018 12:19
@rahulbile rahulbile force-pushed the rb/recurly-pause-resume branch from 96ab55b to f791cfe Compare December 12, 2018 12:36
@aaron-junot
Copy link

Please note that there are a lot of breaking changes between API v2.7 and v2.17. Adding just these two methods will not ensure compatibility between this library and the Recurly API v2.17.

If you want to proceed with this PR, I recommend only updating the X-Api-Version to the minimum version which supports pause and resume (v2.11) while ensuring that other changes between 2.7 and 2.11 are supported.

2.10 is a version that had a lot of changes due to credit memos, so I would spend a good amount of time ensuring that Invoices aren't completely broken in the library due to these changes.

If you go that route, it might be better to break it up into several PRs to avoid having a lot of changes in a single PR.

@rahulbile rahulbile changed the title feat: add pause and resume subscription methods WIP : feat: add pause and resume subscription methods Dec 13, 2018
@rahulbile
Copy link
Contributor Author

Yes @aaron-suarez , thanks for your notes. I did observe that and doing the changes needed. We widely use the recurly API in our application, so giving it a good test. Updated the PR to be WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants