chore: add updated column to blobstream contracts #2192
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @jcstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the Blobstream contracts documentation to enhance clarity regarding data synchronization. This change introduces a new column to the Blobstream contracts table, explicitly stating the update frequency for each listed contract. This addresses a documentation gap, providing users with more comprehensive information about how current the attested data is.
Highlights
- Documentation Update: I've added a new column named "Updated every" to the existing table that lists Blobstream contracts. This column provides crucial information about the data update frequency.
- Update Frequency Specification: For all Blobstream contract entries across various EVM networks (including Ethereum Mainnet, Arbitrum One, Base, Scroll, Sepolia, Arbitrum Sepolia, Base Sepolia, Holesky, and ZKSync Gateway Testnet), the "Updated every" column now explicitly states "1 hour".
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds an "Updated every" column to the Blobstream contracts table in how-to-guides/blobstream.md, indicating a 1-hour update frequency for all listed networks. It also adds a helpful tip for requesting Blobstream deployment on other networks. My review identifies an inconsistency: the table lists a 1-hour update frequency for Ethereum Mainnet, which contradicts existing text in the same document stating a 4-hour update frequency. This should be corrected for clarity and accuracy.
| block range from the `latestBlock` in the contract. | ||
| On Ethereum Mainnet, the contract will be updated | ||
| every 4 hours. | ||
| every hour. |
There was a problem hiding this comment.
can you please double-check this @nuke-web3 ?
There was a problem hiding this comment.
The owner of this I think is Euge, will confirm internally. I think it's best to have the person in charge of updating those to make sure the rates here are correct ongoing.
There was a problem hiding this comment.
I can work with Euge to keep this updated, ty for flagging
|
PR previews expected to fail bc #2150 |
Overview
Resolves #2187