menu: support for secondary subtitles#1098
menu: support for secondary subtitles#1098dima424658 wants to merge 1 commit intocelluloid-player:masterfrom
Conversation
|
Thank you for the patch, but I'm not sure we should be adding this. The reason is that I don't think very many people use secondary subtitles, so it isn't clear if it would be worth dedicating a permanent place for it in the menu. Also, the string "Secondary Subtitle Track" is quite a bit longer than other strings in the menu so it doesn't look very nice. |
|
@gnome-mpv, thank you for the response. I understand that celluloid is positioned as a simple video player, so if you think this functionality is unnecessary, I can close the PR. But there are at least two closed issues, !667 and !797, related to this functionality. Also, many players, such as iina, are capable of playing multiple subtitle tracks.
Perhaps a toggle could be added to the settings to add this option to the menu?
That's the name used in mpv and iina. Do you have any suggestions? |
Technically, we're also capable of displaying secondary subtitles. We don't have a GUI for it, but you can still enable it using a config file or binding custom hotkeys.
I think that might be a good idea. Maybe something more general, like a UI preset for advanced users that enables less common functionalities in the GUI.
I can't really think of a much better name. "2ⁿᵈ Subtitle Track" is a bit shorter but the "2ⁿᵈ" part doesn't look very good either. But if we're only adding the menu item in an advanced user's preset, then I think the aesthetics become less important. |
Use. |
3 participants
No description provided.