Improve responsiveness when opening many files#827
Draft
estorok wants to merge 1 commit intocelluloid-player:masterfrom
Draft
Improve responsiveness when opening many files#827estorok wants to merge 1 commit intocelluloid-player:masterfrom
estorok wants to merge 1 commit intocelluloid-player:masterfrom
Conversation
This commit improves performance when opening or enqueuing many (150+) files at once. Celluloid was unresponsive when it attempted to open many files at once, either as command line arguments or through the --enqueue option. Additionally, the timestamp/scrubber repeatedly jumped between the current video position and 0:00 many times (until the metadata cache update handler had run for each video in the playlist). This is due to too many view updates on the playlist widget. Calling the playlist handler is a heavy operation that updates the contents of the playlist widget, clearing the current playlist model and building another one based off the (up-to-date) internal playlist, which takes O(n) time. I expected that the playlist widget should get updated once per batch file open, but in fact the playlist view was getting regenerated like this at least two times per enqueued file, so processing an opened playlist was O(n^2). The first piece calling playlist updates is the metadata cache update handler (metadata_cache_update_handler in celluloid-controller.c). This handler is run for each new opened file which includes a playlist view update. By running the playlist view update only once at the end of the playlist we get a dramatic speedup, and the timestamp no longer erratically skips between 0:00 and the current time. The second piece responsible is load_file (celluloid-player.c). For each loaded file, the old behavior was to notify the playlist update handler (g_object_notify) if idle. However, the result appeared to be that when enqueuing many files into an idle Celluloid instance, the playlist update handler was called for each, which caused a large slowdown when enqueuing many files. We can instead defer the playlist update to mpv_property_changed which appears to be just as functional.
gnome-mpv
requested changes
Dec 6, 2022
Collaborator
There was a problem hiding this comment.
Thanks for looking into this. From my testing, the patch works fine except for one case where the playlist doesn't get updated properly.
Steps to Reproduce:
- Open a file and let it play to the end.
- Enqueue a new file by running
celluloid --enqueue filename.mkv - Note how the file that was enqueued doesn't appear in the playlist.
Author
|
The problem is indeed that the playlist widget didn't get signaled to update, since the playlist entries eventually appear when becoming non-idle. Idea 1: The Idea 2: Notify the player elsewhere that the playlist changed ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #826