Skip to content

mpv: Prevent blocking in the render update callback for vo=libmpv #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsukinaha wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mpv: Prevent blocking in the render update callback for vo=libmpv #982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d990b7c
mpv: Prevent blocking in the render update callback for vo=libmpv
tsukinaha Sep 28, 2024
c8896c4
Merge branch 'celluloid-player:master' into master
tsukinaha Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/celluloid-mpv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,13 @@ initialize(CelluloidMpv *mpv)
{
g_info("Forcing --vo=libmpv");
mpv_set_option_string(priv->mpv_ctx, "vo", "libmpv");

// According to the libmpv documentation (https://www.ccoderun.ca/programming/doxygen/mpv/render_8h.html#aad9f0d390bf1e49242b9cfe813264314),
// the render update callback will block before the value of video-timing-offset (default 0.050s).
// This significantly reduces smoothness at low frame rates. Setting it to 0 can fix this issue.
mpv_set_option_string(priv->mpv_ctx, "video-timing-offset", "0");
// According to the documentation, when setting this property, we also need to set video-sync=audio.
mpv_set_option_string(priv->mpv_ctx, "video-sync", "audio");
}

mpv_set_wakeup_callback(priv->mpv_ctx, wakeup_callback, mpv);
Expand Down