This repository has been archived by the owner on May 2, 2019. It is now read-only.
Install gulp locally in client build script #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The invocation of ``npm install -g gulp`` in the script may fail if the user doesn't have write access to system directories (usually ``root`` permissions). Also, the later building of resources fails and the build script doesn't detect this: ``` [...] Preparing CENO Portal. * Installing the gulp build tool. npm ERR! tar.unpack untar error /home/ivan/.npm/gulp/3.9.1/package.tgz npm ERR! Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules' [...] * Building resources. ./build.sh: 44: ./build.sh: gulp: not found [SUCCESS] - Compiled CENO Client. ``` This change makes the installation of gulp local and then it invokes the local version in the build script. Since the portal readme mentions that gulp tasks may be run independently, a note is added to point out that installing gulp globally is only needed if the user intends to run these tasks manually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invocation of
npm install -g gulpin the script may fail if the user doesn't have write access to system directories (usuallyrootpermissions). Also, the later building of resources fails and the build script doesn't detect this:This change makes the installation of gulp local and then it invokes the local version in the build script.
Since the portal readme mentions that gulp tasks may be run independently, a note is added to point out that installing gulp globally is only needed if the user intends to run these tasks manually.