feat(s3): wire SIGV4_HEADER_MODE config into davix params#28
Open
mgajek-cern wants to merge 1 commit into
Open
feat(s3): wire SIGV4_HEADER_MODE config into davix params#28mgajek-cern wants to merge 1 commit into
mgajek-cern wants to merge 1 commit into
Conversation
Read a per-endpoint boolean SIGV4_HEADER_MODE from the [S3:HOST] config groups and forward it to davix via RequestParams::setAwsSigV4HeaderMode(), so S3 v4 requests can be signed in Authorization-header form for endpoints whose gateways reject URL-embedded signatures (e.g. Copernicus Data Space). Resolved with the same most-specific-group-wins precedence as ALTERNATE/REGION (S3:HOST -> S3:HOST-no-bucket -> S3); defaults to false, so other S3 endpoints are unchanged. No effect without the paired davix build (signRequestv4 + setAwsSigV4HeaderMode). Closes: cern-fts#27 Depends-on: cern-fts/davix#149 Refs: https://docs.aws.amazon.com/AmazonS3/latest/developerguide/sigv4-auth-using-authorization-header.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No effect without the paired davix build (signRequestv4 + setAwsSigV4HeaderMode).
Closes: #27
Depends-on: cern-fts/davix#149
Reviewer/s: @joaopblopes , @andrea-manzi
Following the discussion with Andrea and Joao regarding the addition of AWS SigV4 header signing for RI-SCALE (Copernicus Data Space interop), either would be suitable to review.