CFE-4591: move_obstructions should replace symlinks #5894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test also serves as the basis for checking additional types of files promises. Ticket: CFE-4591 Changelog: None
|
…ions This is failing. It shows that when move_obstructions is used when the promiser is targeting a symlink that the symlink is not replaced with a plain file. Instead the content of the symlinked file is modified.
|
As expected: |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
| return false; | ||
| } | ||
|
|
||
| const mode_t st_mode = sb->st_mode; |
Check notice
Code scanning / CodeQL
Pointer argument is dereferenced without checking for NULL Note
There was a problem hiding this comment.
@larsewi i had done that safe_attr and safe_sb to avoid this check
There was a problem hiding this comment.
I thought so. But it should not be an issue anymore with the assert's.
Assigning them to a local variable does not really solve the issue. Although, you had some if-statements that in fact does solve it. However, these variables should not be NULL, so an assert be sufficient.
…nt attribute Ticket: CFE-4591 Changelog: Title Co-authored-by: Qwen Code <[email protected]> Co-authored-by: Gemini <[email protected]>
nickanderson
force-pushed
the
CFE-4591/master
branch
from
b235aba to
e9a8f71
Compare
edit_template_string is only used with template_method inline_mustache.
An `assert` should be sufficient to let the static analysis tools know that these pointers are not `NULL`. Please squash this one with e9a8f71. Signed-off-by: Lars Erik Wik <[email protected]>
Handle the edge case where obstruction filepath is too long to fit in `backup` buffer. Please squash with e9a8f71. Signed-off-by: Lars Erik Wik <[email protected]>
Please squash with e9a8f71. Signed-off-by: Lars Erik Wik <[email protected]>
Please squash with e9a8f71 Signed-off-by: Lars Erik Wik <[email protected]>
craigcomstock
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for copy_from which already respects move_obstructions. Foundation for testing other files promise behavior with move_obstructions and symlinks.
Ticket: CFE-4591