Fix issue #16 https://github.com/cfortune/PHP-Bounce-Handler/issues/16#17
Open
rbairwell wants to merge 15 commits intocfortune:masterfrom
Open
Fix issue #16 https://github.com/cfortune/PHP-Bounce-Handler/issues/16#17rbairwell wants to merge 15 commits intocfortune:masterfrom
rbairwell wants to merge 15 commits intocfortune:masterfrom
Conversation
…PDOC style comments
…split() is deprecated as of PHP5.3.0. Added a few more return/parameter type comments, fix uncommented 'boundary' content-type and check more for existance of array before comparing contents
…ce files are not necessarily needed (but are loaded if the parameters are not provided for backwards compatibility). Change file header to be PHPDocumentor compliant. General code cleanup and commenting.
…to http://localhost:8000/testdriver1.php and also add a bit more information about the results. Fix a few edge case issues in the main class highlighted by the "test harness"
…nger than 4 characters or shorter than 2) and "odder" email addresses
… the testdriver. Allow the "human readable" status code to be extracted in an array instead of being forced as HTML. Improve handling of non-standard (2.0) style reports (instead of just the RFC supporting 2.0.0). Fix issue where include_once was used - should have just been include/require
… backwards compatibility by renaming methods. General tidyup and ensuring bounce_responses stays in PEAR format after updates
…ing properly classified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the use of /e in preg_replace as per @Orayi suggestion in #16 (see commit 165ce06 ).
Lots of other changes including: