Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paying for College: Dynamic Disclosures - Bug Fixes #8719

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

mistergone
Copy link
Member

@mistergone mistergone commented Jan 16, 2025

This PR will address a few bugs in our Paying for College "Dynamic Disclosures" application. It fixes a bug with Private Loans, a style bug with numeric icons and unordered lists, and a fix for the Print Button in the final step of the disclosure.

Changes

  • Run enumeratePrivateLoans() on init to fix Remove Button bug
  • Fix numbered icons padding in Part 3 list
  • Fix print button

How to test this PR

  1. Try to remove the first Private Loan (without adding one). There should be no error.
  2. Check on the numbered icons and make sure they don't overlap text in "Next Steps"
  3. Make sure the Print button in "Next Steps" shows the browser's print dialog.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

- Run enumeratePrivateLoans() on init to fix Remove Button bug
Copy link
Member

@higs4281 higs4281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed for me, including the printed version.

@mistergone mistergone added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 70ced1d Jan 16, 2025
11 checks passed
@mistergone mistergone deleted the dd-fixes branch January 16, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants