Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify S3 configuration #5

Closed
wants to merge 1 commit into from
Closed

Simplify S3 configuration #5

wants to merge 1 commit into from

Conversation

chosak
Copy link
Member

@chosak chosak commented Nov 21, 2024

This commit simplifies the Django settings S3 configuration setting. We assume that AWS credentials are properly configured via the environment, and only provide the S3 bucket name to Django.

These changes come from @cooldragontattoo's cool add-gha branch.

This commit simplifies the Django settings S3 configuration setting.
We assume that AWS credentials are properly configured via the
environment, and only provide the S3 bucket name to Django.
@cooldragontattoo
Copy link
Contributor

@chosak -- I think you are trying to merge the wrong branch. I opened up a new PR with the add-gha branch.

@chosak
Copy link
Member Author

chosak commented Nov 25, 2024

Closing as these changes went in with #6.

@chosak chosak closed this Nov 25, 2024
@chosak chosak deleted the feature/simplify-s3 branch November 25, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants