2311-keycloak-impersonate #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meissadia
reviewed
Feb 4, 2025
| @@ -1,17 +1,20 @@ | |||
| ARG NODE_VERSION='20.9.0' | |||
There was a problem hiding this comment.
Looks like this env variable is no longer used. Could this be integrated into line 5 to drive the node version of the Cypress image?
meissadia
reviewed
Feb 4, 2025
| @@ -1,17 +1,20 @@ | |||
| ARG NODE_VERSION='20.9.0' | |||
| ARG CYPRESS_VERSION='13.3.1' | |||
| ARG CYPRESS_VERSION='13.5.0' | |||
There was a problem hiding this comment.
Looks like this env variable is no longer used. Could this be integrated into line 15 to drive the version of the Cypress image?
meissadia
reviewed
Feb 4, 2025
|
|
||
| # Set working directory | ||
| WORKDIR /hmda-frontend | ||
|
|
||
| USER root | ||
| RUN apt-get update && apt-get install -y curl nodejs npm microsoft-edge-stable |
There was a problem hiding this comment.
Is nodejs needed here if Node is already included in the cypress/browsers image?
meissadia
reviewed
Feb 4, 2025
| #RUN apt-get install -y curl | ||
|
|
||
| COPY cypress/package.json ./ | ||
| RUN npm install [email protected] --save-dev |
There was a problem hiding this comment.
I see cypress already included in the cypress/package.json file. Could this install (Line 15) instead be managed by updating that Cypress version via the package file? Then Line 15 becomes npm install.
meissadia
reviewed
Feb 4, 2025
|
|
||
| # Set working directory | ||
| WORKDIR /hmda-frontend | ||
|
|
||
| USER root | ||
| RUN apt-get update && apt-get install -y curl nodejs npm microsoft-edge-stable | ||
| #RUN apt-get install -y curl |
There was a problem hiding this comment.
Suggested change
| #RUN apt-get install -y curl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2311