xplat: remove win64 - #4604
Merged
Merged
xplat: remove win64#4604
Conversation
xplat was using some x86 codes / definitions for x64 due to win64 macro usage. This PR will fix some of the slow test fails those we were experiencing recently on ccrobot
sethbrenith
approved these changes
Jan 26, 2018
jackhorton
reviewed
Jan 26, 2018
| BackwardPass::DoTrackBitOpsOrNumber() const | ||
| { | ||
| #if _WIN64 | ||
| #if defined(_WIN32) && defined(TARGET_64) |
Contributor
There was a problem hiding this comment.
Minor thing but I noticed that _WIN32 seems to be explicitly set to 1 sometimes, so maybe just check if _WIN32 && defined... ?
| static int GetBufferOffset() { return offsetof(ArrayBuffer, buffer); } | ||
|
|
||
| virtual void AddParent(ArrayBufferParent* parent) override; | ||
| #if _WIN64 |
Contributor
There was a problem hiding this comment.
Comment below mentions amd64 -- should this be _M_X64 instead? (theres a similar use in SharedArrayBuffer.h)
Collaborator
Author
There was a problem hiding this comment.
The numbers there are not vendor dependent.
Collaborator
Author
|
@sethbrenith @jackhorton Thanks for the review |
chakrabot
pushed a commit
that referenced
this pull request
Jan 26, 2018
Merge pull request #4604 from obastemur:fix_target_64 xplat was using some x86 codes / definitions for x64 due to win64 macro usage. This PR fixes some of the slow test fails those we were experiencing recently on ccrobot.
chakrabot
pushed a commit
that referenced
this pull request
Jan 26, 2018
Merge pull request #4604 from obastemur:fix_target_64 xplat was using some x86 codes / definitions for x64 due to win64 macro usage. This PR fixes some of the slow test fails those we were experiencing recently on ccrobot.
chakrabot
pushed a commit
that referenced
this pull request
Jan 26, 2018
Merge pull request #4604 from obastemur:fix_target_64 xplat was using some x86 codes / definitions for x64 due to win64 macro usage. This PR fixes some of the slow test fails those we were experiencing recently on ccrobot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xplat was using some x86 codes / definitions for x64 due to win64 macro usage.
This PR fixes some of the slow test fails those we were experiencing recently on ccrobot.