Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(field): add aria-describedby to Field component #3307

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jeferson-sb
Copy link
Contributor

Description

Add aria-describedby based on the Field helper text
closes #3301

Copy link

vercel bot commented Feb 16, 2025

@jeferson-sb is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/react@3307
npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/solid@3307
npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/vue@3307
npm i https://pkg.pr.new/chakra-ui/ark/@ark-ui/svelte@3307

commit: 8d428f7

@jeferson-sb jeferson-sb changed the title feat(field): add aria-describedbly to Field component feat(field): add aria-describedby to Field component Feb 16, 2025
Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🙏

I do left my remarks on this issue.
Also, is it possible if you find the solution to make it happen for the other frameworks too (Vue and Solid)?

Thanks!

@jeferson-sb
Copy link
Contributor Author

@carwack Is there an option to run storybook for Solid or Vue, I couldn't find one

@jeferson-sb
Copy link
Contributor Author

@carwack Can you also check why some of these files got formattted the way they are?

@carwack
Copy link
Collaborator

carwack commented Feb 20, 2025

Hi @jeferson-sb,
Thanks for the work!

@carwack Is there an option to run storybook for Solid or Vue, I couldn't find one

You can use the following commands
Solid: bun solid storybook -> we noticed there is a bug on the solid storybook package which might break your build (no solution so far so if that happens, we have to skip it)/
Vue: bun vue storybook -> currently using Histoire for the stories.

@carwack Can you also check why some of these files got formattted the way they are?
I noticed this as well, I wonder if this is because of new or different prettier rules. I will have to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FieldInput does not receive aria-describedby when FieldHelper is used.
2 participants