Minor_edits_doc #298
Open
Minor_edits_doc #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapatil211
requested changes
Aug 16, 2022
Comment on lines
32
to
37
| self._q_values = np.zeros(obs_dim, act_dim) | ||
| self._gamma = gamma | ||
| self._alpha = alpha | ||
| self._act_dim = act_dim | ||
| self._epsilon_schedule = LinearSchedule(1.0, final_epsilon, explore_steps) | ||
Collaborator
There was a problem hiding this comment.
This tutorial needs to be updated based on the new api. We no longer pass act_dim and obs_dim, we instead pass spaces. Can you please update the tutorial?
| defaults to :py:class:`~torch.optim.Adam`. | ||
| critic_optimizer_fn (OptimizerFn): A function that takes in the list of | ||
| parameters of the critic returns the optimizer for the critic. If None, | ||
| parameters of the critic and returns the optimizer for the critic. If None, |
Collaborator
There was a problem hiding this comment.
Please make sure any changes to docstrings/comments result in lines <=88 columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.