-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse through NCBITaxon ancestors #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 89.41% 89.41%
=======================================
Files 19 19
Lines 1361 1361
Branches 125 125
=======================================
Hits 1217 1217
Misses 124 124
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
927295a
to
5c84c42
Compare
nayib-jose-gloria
approved these changes
Feb 6, 2025
Merged
joyceyan
pushed a commit
that referenced
this pull request
Feb 6, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>python-api: 1.4.2</summary> ## [1.4.2](python-api-v1.4.1...python-api-v1.4.2) (2025-02-06) ### BugFixes * parse through NCBITaxon ancestors ([#259](#259)) ([c461251](c461251)) </details> <details><summary>ontology-assets: 1.3.2</summary> ## [1.3.2](ontology-assets-v1.3.1...ontology-assets-v1.3.2) (2025-02-06) ### BugFixes * parse through NCBITaxon ancestors ([#259](#259)) ([c461251](c461251)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
previously, we skipped over parsing through
NCBITaxon
ancestors since we had no prior use for this. now that we do have a use, we should actually parse through this so that we understand the ancestor / descendant terms.this retains the filter to only go through a subgraph of the
NCBITaxon
graph that'sNCBITaxon:33208
(Animal) or below.note that previously, the
ontology-processing
job took 24 mins. with this change, it will take 2 hrs 5 mins. the generatedNCBITaxon-ontology.json
also increased in size from 140 MB to 990 MB.Testing
download ontology asset and inspect "NCBITaxon:10090" (mus musculus). previously, this is what we had:
now, we have: