Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse through NCBITaxon ancestors #259

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Conversation

joyceyan
Copy link
Contributor

@joyceyan joyceyan commented Feb 3, 2025

Reason for Change

previously, we skipped over parsing through NCBITaxon ancestors since we had no prior use for this. now that we do have a use, we should actually parse through this so that we understand the ancestor / descendant terms.

this retains the filter to only go through a subgraph of the NCBITaxon graph that's NCBITaxon:33208 (Animal) or below.

note that previously, the ontology-processing job took 24 mins. with this change, it will take 2 hrs 5 mins. the generated NCBITaxon-ontology.json also increased in size from 140 MB to 990 MB.

Testing

download ontology asset and inspect "NCBITaxon:10090" (mus musculus). previously, this is what we had:

  "NCBITaxon:10090": {
    "ancestors": {},
    "label": "Mus musculus",
    "synonyms": [
      "house mouse",
      "mouse"
    ],
    "deprecated": false
  },

now, we have:

"NCBITaxon:100900": {
    "ancestors": {
      "NCBITaxon:2162899": 1,
      "NCBITaxon:39087": 2,
      "NCBITaxon:337677": 3,
      "NCBITaxon:337687": 4,
      "NCBITaxon:1963758": 5,
      "NCBITaxon:9989": 6,
      "NCBITaxon:314147": 7,
      "NCBITaxon:314146": 8,
      "NCBITaxon:1437010": 9,
      "NCBITaxon:9347": 10,
      "NCBITaxon:32525": 11,
      "NCBITaxon:40674": 12,
      "NCBITaxon:32524": 13,
      "NCBITaxon:32523": 14,
      "NCBITaxon:1338369": 15,
      "NCBITaxon:8287": 16,
      "NCBITaxon:117571": 17,
      "NCBITaxon:117570": 18,
      "NCBITaxon:7776": 19,
      "NCBITaxon:7742": 20,
      "NCBITaxon:89593": 21,
      "NCBITaxon:7711": 22,
      "NCBITaxon:33511": 23,
      "NCBITaxon:33213": 24,
      "NCBITaxon:6072": 25,
      "NCBITaxon:33208": 26,
      "NCBITaxon:33154": 27,
      "NCBITaxon:2759": 28,
      "NCBITaxon:131567": 29,
      "NCBITaxon:1": 30
    },
    "label": "Alexandromys middendorffii",
    "synonyms": [
      "Middendorf's vole"
    ],
    "deprecated": false
  },

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.41%. Comparing base (d27fe21) to head (4656b5d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   89.41%   89.41%           
=======================================
  Files          19       19           
  Lines        1361     1361           
  Branches      125      125           
=======================================
  Hits         1217     1217           
  Misses        124      124           
  Partials       20       20           
Flag Coverage Δ
unittests 89.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joyceyan joyceyan force-pushed the joyce/bump-NCBITaxon branch from 927295a to 5c84c42 Compare February 6, 2025 19:03
@joyceyan joyceyan changed the title chore: bump NCBITaxon version up fix: parse through NCBITaxon ancestors Feb 6, 2025
@joyceyan joyceyan merged commit c461251 into main Feb 6, 2025
3 checks passed
@joyceyan joyceyan deleted the joyce/bump-NCBITaxon branch February 6, 2025 22:16
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
joyceyan pushed a commit that referenced this pull request Feb 6, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>python-api: 1.4.2</summary>

##
[1.4.2](python-api-v1.4.1...python-api-v1.4.2)
(2025-02-06)


### BugFixes

* parse through NCBITaxon ancestors
([#259](#259))
([c461251](c461251))
</details>

<details><summary>ontology-assets: 1.3.2</summary>

##
[1.3.2](ontology-assets-v1.3.1...ontology-assets-v1.3.2)
(2025-02-06)


### BugFixes

* parse through NCBITaxon ancestors
([#259](#259))
([c461251](c461251))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants